Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snow DA update and recentering for the EnKF forecasts #2690

Open
wants to merge 60 commits into
base: develop
Choose a base branch
from
Open

Add snow DA update and recentering for the EnKF forecasts #2690

wants to merge 60 commits into from

Conversation

CoryMartin-NOAA
Copy link
Contributor

Description

Apologies in that this is a fairly substantial PR, but a lot of things were needed to make this happen. This PR adds the capability to update the ensemble of snow states by recentering the ensemble mean to the deterministic snow analysis and applying increments as appropriate.

Resolves #2585

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES in the sense that results will change
  • Does this change require a documentation update? Maybe?

How has this been tested?

  • Cycled test on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@CoryMartin-NOAA
start to add new task
b0656aa
@CoryMartin-NOAA
add new j-job
d16119d
@CoryMartin-NOAA
Save to do some initial testing
b4c97f8
@CoryMartin-NOAA
more updates
3667349
@CoryMartin-NOAA
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
accc4f4
@CoryMartin-NOAA
Merge branch 'develop' into feature/snow-ensemble
e565f21
@CoryMartin-NOAA
end of day commit
81b7b6e
@CoryMartin-NOAA
End of day/week commit
3aaa8f6
@CoryMartin-NOAA
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
7085716
@CoryMartin-NOAA
save
29641b2
@CoryMartin-NOAA
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
531136a 
…-NOAA/global-workflow into feature/snow-ensemble
@CoryMartin-NOAA
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
7491c35
@CoryMartin-NOAA
snow changes
d57e12f
@CoryMartin-NOAA
end of day commit
89fd461
@CoryMartin-NOAA
stage files is working
f26822e
@CoryMartin-NOAA
save updates
2460af1
@CoryMartin-NOAA
more updates
057996d
@CoryMartin-NOAA
make norm happy
146dc60
@CoryMartin-NOAA
Merge branch 'develop' into feature/snow-ensemble
cff98a0
@CoryMartin-NOAA
norm is an angry old man
d7afb7b
@CoryMartin-NOAA
remove esnowanl from enkfgfs
eb5716d
@CoryMartin-NOAA
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
256e182 
…-NOAA/global-workflow into feature/snow-ensemble
@CoryMartin-NOAA
end of day commit
6a57a64
@CoryMartin-NOAA
fregrid working but seems a bit hacky
ebb3c31
@CoryMartin-NOAA
norms and remove commented out code
2bdee22
@CoryMartin-NOAA
Merge branch 'develop' into feature/snow-ensemble
99fdfbe
@CoryMartin-NOAA
update snow ens
42b3fbe
@CoryMartin-NOAA
Merge branch 'develop' into feature/snow-ensemble
a950c80
@CoryMartin-NOAA
update some submodules
f380223
@CoryMartin-NOAA
update some things
73894dc
@CoryMartin-NOAA
fix method call
aeb3f79
@CoryMartin-NOAA
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
06c8e3a 
…-NOAA/global-workflow into feature/snow-ensemble
@CoryMartin-NOAA
coding norms
f23aa20
@CoryMartin-NOAA
end of week commit
4ba1cdc
@CoryMartin-NOAA
one more end of week commit
d0d711a
@CoryMartin-NOAA
smore changes
18e7bd4
@CoryMartin-NOAA
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
7370a0c 
…-NOAA/global-workflow into feature/snow-ensemble
@CoryMartin-NOAA
ensmean to ensstat
b029f90
@CoryMartin-NOAA
IAU changes
18aaafa
@CoryMartin-NOAA
coding norms + more IAU fixes
135c57f
@CoryMartin-NOAA
Merge branch 'develop' into feature/snow-ensemble
dde7463
@CoryMartin-NOAA
Update gdas
9c47927
@CoryMartin-NOAA
update enkf sfc update
33f6080
@CoryMartin-NOAA
more changes
0643c95
@CoryMartin-NOAA
update ci case
54539cd
@CoryMartin-NOAA
fix dependencies
554b545
@CoryMartin-NOAA
ignore these bufr2ioda links
aa43118
@CoryMartin-NOAA
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
d6dae13
@CoryMartin-NOAA
fixing some bugs
fa8dd8a
@CoryMartin-NOAA
Merge branch 'feature/snow-ensemble' of https://github.com/corymartin…
c24d026 
…-noaa/global-workflow into feature/snow-ensemble
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 14, 2024
View reviewed changes
scripts/exgdas_enkf_sfc.sh Fixed Show fixed Hide fixed
scripts/exgdas_enkf_sfc.sh Fixed Show fixed Hide fixed
scripts/exgdas_enkf_sfc.sh Fixed Show fixed Hide fixed
jobs/JGLOBAL_PREP_SNOW_OBS Fixed Show fixed Hide fixed
jobs/JGLOBAL_PREP_SNOW_OBS Fixed Show fixed Hide fixed
jobs/JGLOBAL_SNOW_ENSEMBLE_ANALYSIS Fixed Show fixed Hide fixed
jobs/JGLOBAL_SNOW_ENSEMBLE_ANALYSIS Fixed Show fixed Hide fixed
jobs/JGLOBAL_SNOW_ENSEMBLE_ANALYSIS Fixed Show fixed Hide fixed
scripts/exgdas_enkf_sfc.sh Fixed Show fixed Hide fixed
scripts/exgdas_enkf_sfc.sh Fixed Show fixed Hide fixed
@CoryMartin-NOAA
Copy link
Contributor Author

@jiaruidong2017 I've tested this but can you try it out and see if you find any issues running under a different account from my own. Thanks!

@jiaruidong2017
Copy link
Contributor

@jiaruidong2017 I've tested this but can you try it out and see if you find any issues running under a different account from my own. Thanks!

@CoryMartin-NOAA I will try it, and let you know then.

@CoryMartin-NOAA
Copy link
Contributor Author

Reviewers, please note that this PR currently points to a hash of gdas.cd which is not in develop yet, so this should not be merged until the gdas.cd hash is updated.

@jiaruidong2017
Copy link
Contributor

@CoryMartin-NOAA Would you please tell me where is your experiment directory for this PR? Thanks.

@CoryMartin-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA Would you please tell me where is your experiment directory for this PR? Thanks.

@jiaruidong2017 on Hera see /scratch1/NCEPDEV/stmp2/Cory.R.Martin/tmp_june2024/snowens/exp/snowenstest

@jiaruidong2017
Copy link
Contributor

@jiaruidong2017 I've tested this but can you try it out and see if you find any issues running under a different account from my own. Thanks!

@CoryMartin-NOAA I have cloned your repo and built the global-workflow under your branch of CoryMartin-NOAA:feature/snow-ensemble. Then, I setup the experiment, and conducted the test run. The test run was technically successful. Therefore, this PR is ready to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snow ensemble "analysis" and recentering
2 participants
@CoryMartin-NOAA @jiaruidong2017