-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNSS-R L2 ocean wind speed assimilation (Spire Global, Inc. and NASA/CYGNSS) #628
Comments
@KariA-Spire , please note the following information posted on the GSI wiki
|
@KariA-Spire , your branch, |
@RussTreadon-NOAA, I deleted gnssrwnd and created a new branch https://github.com/KariA-Spire/GSI/tree/gnssrwnd1.0, which is synced with develop. |
Please review information posted under the GSI Wiki and follow the outlined procedure to move this issue forward. Key pages include Code Management Policy and How to Make Changes. |
@KariA-Spire : Attempts to compile gnssrwnd1.0 on WCOSS2 (Cactus) fail with numerous errors
Additionally, several routines contain sections which look to be unresolved git conflicts. For example,
Which NOAA RDHPCS machine(s) can you access? |
@KariA-Spire , thank you for updating your branch. I updated my working copy to 5f7f4dd. The WCOSS2 build still failed. The following modifications were needed
If you have access to a NOAA RDHPCS machine I can copy the above modifications to a place where you can see them. Alternatively I can attempt to push to your branch but I'm not sure if this will work. |
Hi @RussTreadon-NOAA , |
@KariA-Spire , I updated my working copy of gnssrwnd1.0. While your branch at 1aa6743 compiles, I don't think the all An The Please check your working copy of |
The initial attempt to run the new code through ctests on WCOSS2 was unsuccessful. All ctests running
Line 243 of
A search for
The array is declared and deallocated but it is never allocated or initialized. More importantly,
The above was repeated on NOAA RDHPCS Hera with all tests passing on Hera.
None of the existing ctests include GNSS-R ocean wind speed observations. As such, the above ctests do not address the question as to whether or not the new code actually works as intended. Even if a bufr dump file containing the new data were available additional changes are needed
|
As for the additional changes, if you point me to NOAA-specific runscript, OBS_INPUT namelist, and convinfo files I'd be happy to update them. Meanwhile, the following lines need to be added to the specified scripts:
Files like "gfs.t12z.spirewnd.tm00.bufr_d" or "gfs.t12z.cygnswnd.tm00.bufr_d need to be linked to gnssrwndbufr in a runscript for GSI processing.
OBS_INPUT::
I could also provide BUFR dump files to facilitate testing. |
GSI scripts and fix files are managed in other repositories. It is sufficient at this time if you can confirm from your side that the code in gnssrwnd1.0 behaves as expected. |
I can confirm that the code in gnssrwnd1.0 behaves as expected in Spire's DA system. |
What do you think about Execution on WCOSS2 and Hera fails because array |
The rhs_split_gps array is unrelated to the gnssrwnd1.0 development. I can commit the change to m_rhs.90 if you think that's best. |
If we leave |
Done! |
Problems remain with |
Thank you @KariA-Spire for updating |
Thank you @RussTreadon-NOAA for your guidance! |
@KariA-Spire , the next step is to open a GSI Pull Request. This is step 4 under GSI wiki page GSI:-How-to-Make-Changes |
@KariA-Spire, please open a GSI pull request if you would like the changes in |
@RussTreadon-NOAA, thanks for the reminder. I created the pull request: #747 |
Thank you @KariA-Spire |
Description
Type of Change
How Has This Been Tested?
Checklist
File Changes
M gsimain.f90
M gsi_obOperTypeManager.F90
M intjo.f90
M _rhs.F90
M obsmod.F90
M setuprhsall.f90
M statsconv.f90
M convinfo.f90
M read_obs.F90
N gsi_gnssrspdOper.F90
N intgnssrspd.f90
N m_gnssrspdNode.F90
N read_gnssrspd.f90
N setupgnssrspd.f90
N stpgnssrspd.f90
Link to the forked branch:https://github.com/KariA-Spire/GSI/tree/gnssrwnd1.0
Note: Upon request, we can facilitate source code for NCEP-flavor BUFR encoders and JEDI/IODA converters. We can also guide users on observation error and bias correction treatment on an "as-time-permits" basis.
Spire Global, Inc. developed this assimilation capability under the NASA CYGNSS ROSES-2020 Grant number 80NSSC21K1120.
The text was updated successfully, but these errors were encountered: