Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new property CachedUntil to CachedLayoutRendererWrapper #4309

Open
snakefoot opened this issue Feb 15, 2021 · 6 comments
Open

Add new property CachedUntil to CachedLayoutRendererWrapper #4309

snakefoot opened this issue Feb 15, 2021 · 6 comments

Comments

@snakefoot
Copy link
Contributor

snakefoot commented Feb 15, 2021

If wanting to refresh the cached-value every 1 minutes. Then one can do this:

${local-ip:cachedSeconds=60}

But if wanting to refresh the cached-value every day (or every hour), then things get more blurry, as it will only work when application startup exactly at midnight.

Instead it should also be possible to do this:

${local-ip:cachedUntil=HourChange}

And it will reset the cached value exactly when the hour-changes. See also: JDetmar/NLog.Extensions.AzureStorage#93

@304NotModified
Copy link
Member

Maybe rename it to cacheResetOn?

@snakefoot
Copy link
Contributor Author

I like to keep them similar: "Cached", "CachedSeconds", "CachedDuration".

@snakefoot
Copy link
Contributor Author

Maybe merge CachedDuration together with ClearCache

@304NotModified
Copy link
Member

Duration sounds the same as seconds. I expect with cacheDuration=hour == cacheSeconds=3600

@snakefoot
Copy link
Contributor Author

CachedUntil ?

@304NotModified
Copy link
Member

Sounds good!

@304NotModified 304NotModified changed the title Add new property CachedDuration to CachedLayoutRendererWrapper Add new property CachedUntil to CachedLayoutRendererWrapper Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants