New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Play framework interacts weird with active timer #3123

Open

osheroff opened this issue Aug 7, 2022 · 0 comments

Labels

osheroff commented Aug 7, 2022

Describe the bug
With a running timer, starting to play a song with the CPS asks "do you want to stop the running timer"? This line:

mycroft-core/mycroft/skills/common_play_skill.py

Line 163 in 1b67bf3

self.bus.emit(message.forward("mycroft.stop"))

emits a "mycroft.stop" event, which is interpreted by the timer skill as intending to stop the timer.

To Reproduce
Steps to reproduce the behavior:

"Start a timer for 5 minutes"
"Play songs by Tom Waits on Spotify"

osheroff added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment