Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Power not drawn until gate is closed (investigate) #303

Open
Manglefan opened this issue Apr 6, 2021 · 9 comments · May be fixed by #311
Open

Power not drawn until gate is closed (investigate) #303

Manglefan opened this issue Apr 6, 2021 · 9 comments · May be fixed by #311
Labels
bug Something isn't working fixed-in-dev Issue is fixed in development branch (or pull request) and waiting for merge
Projects

Comments

@Manglefan
Copy link

in the latest beta when i dialed the gate the power drains the longer its open but in the latest alpha when i dial the gate the power doesnt drain or it doesnt lose power till the gate is shut down

@MrJake222 MrJake222 added the bug Something isn't working label Apr 7, 2021
@MrJake222 MrJake222 added this to To do in Fix bugs via automation Apr 7, 2021
@MrJake222 MrJake222 changed the title idk if this a bug or not Power not drawn until gate is closed (investigate) Apr 7, 2021
@xnerhu
Copy link

xnerhu commented May 16, 2021

It seems that this commit from @slava110 has broken power draw. After some investigation I found out that extractEnergy in StargateAbstractEnergyStorage doesn't work because energy property in this class is always 0.

@MrJake222

@xnerhu
Copy link

xnerhu commented May 16, 2021

Also I think it has something with amount of naquadah in DHD. If it's around 0-700 then power draw is 0.

@Manglefan
Copy link
Author

ive tried with a full DHD and it doesnt work what do i set the StargateAbstractEnergyStorage to

@MrJake222
Copy link
Owner

@slava110

@slava110
Copy link
Contributor

After some investigation I found out that extractEnergy in StargateAbstractEnergyStorage doesn't work because energy property in this class is always 0.

StargateAbstractEnergyStorage wasn't modified in this commit
And energy shouldn't be always 0 if deserialization and serialization works properly
Checked code and it might be the problem
https://github.com/sentialx/AUNIS/blob/7029efdcb88b49583520a0b49e76553ee8996fa6/src/main/java/mrjake/aunis/stargate/power/StargateItemEnergyStorage.java#L26

@MrJake222
Copy link
Owner

Why y'all posting links to the sentialx repo?

@slava110
Copy link
Contributor

slava110 commented May 17, 2021

Why y'all posting links to the sentialx repo?

He sent link to my commit so it's easier for me to click on this link to find the problem

@xnerhu
Copy link

xnerhu commented May 17, 2021

Why y'all posting links to the sentialx repo?

Yeah, sorry xd. I'm working with Sentialx to fix and add some stuff.

@xnerhu xnerhu linked a pull request May 17, 2021 that will close this issue
@Manglefan
Copy link
Author

So this'll be fixed and how do I add it to my version

slava110 added a commit that referenced this issue Aug 19, 2021
- Changed `StargateItemEnergyStorage` so now it extends `StargateAbstractEnergyStorage` and will have unused global variable (discussed in #314)
- Additional constructors for `StargateAbstractEnergyStorage`
@slava110 slava110 added the fixed-in-dev Issue is fixed in development branch (or pull request) and waiting for merge label Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-dev Issue is fixed in development branch (or pull request) and waiting for merge
Projects
Fix bugs
  
To do
Development

Successfully merging a pull request may close this issue.

4 participants