Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Logic for Opened URL for Royale Application Deployment #1187

Open
JoelProminic opened this issue Jan 26, 2023 · 0 comments
Open

Improve Logic for Opened URL for Royale Application Deployment #1187

JoelProminic opened this issue Jan 26, 2023 · 0 comments

Comments

@JoelProminic
Copy link
Contributor

When we originally implemented #1080, we defaulted the opened URL to http://127.0.0.1:8080/... to work with the original DominoVagrant configuration. Now that we have switched to demo-tasks (see #1186), We need to support URLs like https://domino.demo.startcloud.com/... instead.

Some options for this:

  • Configure the Base URL in the Royale project. This is flexible, but requires manual work.
  • Read a baseURL property from the REST interface as part of /info. This requires some updates to the Vagrant configuration and REST interface, but it shouldn't be too hard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Moonshine-IDE - Bug Fixing
  
Awaiting triage
Development

No branches or pull requests

1 participant