Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit status should be non-zero if some file(s) couldn't be written to #29

Open
Shados opened this issue Jun 23, 2020 · 0 comments
Open

Comments

@Shados
Copy link

Shados commented Jun 23, 2020

I've come across some strangely-encoded* FLAC files in my library which loudgain gave a "Couldn't write to" error for. However, because loudgain doesn't exit with an error status in such cases, I only detected the issue well after the fact, while I was separately checking files for the presence of RG tags.

If loudgain were instead to exit with a non-zero code when encountering issues like this, wrapper scripts like rgbpm would be able to sanely detect and report issues to the user.


*: Somehow the original encoder managed to have a metadata block type other than STREAMINFO as block 0, which is I presume what caused loudgain to refuse to write to the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant