-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Replace registered runner for organization
step is missing from install_runner.yml
#207
Labels
bug
Something isn't working
Comments
samgiz
changed the title
bug: Replace registered runner for organization ste
bug: Replace registered runner for organization step is missing
May 10, 2024
samgiz
changed the title
bug: Replace registered runner for organization step is missing
bug: May 10, 2024
Replace registered runner for organization
step is missing
samgiz
changed the title
bug:
bug: May 10, 2024
Replace registered runner for organization
step is missingReplace registered runner for organization
step is missing from install_runner.yml
After another look I now see that the two |
Troels51
added a commit
to Troels51/ansible-github_actions_runner
that referenced
this issue
May 14, 2024
When replacing an existing runner, it makes no sense to restrict it to not run on org runners. This commit removes that requirement closes: MonolithProjects#207
lewismiddleton
added a commit
to lewismiddleton/ansible-github_actions_runner
that referenced
this issue
May 14, 2024
This removes a condition from the 'Replace registered runner' task to allow it to replace organisation runners. Resolves MonolithProjects#207 Resolves MonolithProjects#145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The
Replace registered runner for organization step
step used to exist and got removed in this commit, even though that change isn't mentioned in the commit message.I'm assuming that was an accidental removal. I don't see a reason to have a
Replace registered runner
step for repos but not organizations, and I don't think it's currently possible to re-register an organization runner.Issue Type
Bug Report
Ansible Version
1.15.0 and later.
Steps to Reproduce
I'm not knowledgable enough about ansible to quickly set up a full small reproducer. I have something similar to the following snippet in my config:
Expected Results
I would expect the runner to be reinstalled when
reinstall_runner
is true.Actual Results
It doesn't get reinstalled, because it never gets reinstalled for organization runners as currently written.
The text was updated successfully, but these errors were encountered: