Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave blocks Alertify #256

Open
zakarialounes opened this issue Nov 5, 2022 · 6 comments
Open

Brave blocks Alertify #256

zakarialounes opened this issue Nov 5, 2022 · 6 comments

Comments

@zakarialounes
Copy link

With the Brave new feature to prevent cookie windows, alertify (notifier) no longer works. To test I invite you to follow the procedure described at https://brave.com/privacy-updates/21-blocking-cookie-notices/.

By modifying the defined classes it is possible to circumvent this, except that alertify does not take into account the modification of the notify classes defined in configuration. I looked a bit in the code and indeed it uses the classes defined in the defaults object.

@viplike
Copy link

viplike commented Nov 9, 2022

I confirm this: notifications don't work in brave, but work in google chrome. Brave recognizes alertify as ad banner and blocks it. You can check it by disabling ad block in: Shields -> Block ads and trackers -> Disable (I'm not sure in menu translation because I have Russian version of a browser)

@zakarialounes
Copy link
Author

@viplike personally I never had any problem with Alertify and Brave, until Brave added this new feature, namely "Blocking cookie notices" which in fact adds a blocking list from "Easylist-Cookie List - Filter Obtrusive Cookie Notices", as stated in the article quoted above.

@viplike
Copy link

viplike commented Nov 10, 2022

@keupsonite hey, agree with you, I don't see my notifications after clicking on disabling cookie notices

@MohammadYounes
Copy link
Owner

It seems they get filtered out based on class name. The solution is to rename notifier class names.

related #232

@zakarialounes
Copy link
Author

It seems they get filtered out based on class name. The solution is to rename notifier class names.

related #232

Except that as I said in my first message @MohammadYounes, the modification of the classes for the notifier it is not taken into account.

@Benadato
Copy link

Same issue. Works great on most browsers, but use Brave extensively and Alertify has issues showing any error, success, etc messages that are temporarily displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants