Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KHR_materials_pbrSpecularGlossiness #75

Open
el-dee opened this issue Jun 27, 2020 · 2 comments
Open

Add support for KHR_materials_pbrSpecularGlossiness #75

el-dee opened this issue Jun 27, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@el-dee
Copy link
Contributor

el-dee commented Jun 27, 2020

As more and more models are using this extension, I think it's becoming a required addition to the importer.

On itself it's not very complicated to add it, however I'm wondering how to make it work with simplepbr. We could have a global flag in simplepbr to select the workflow, either metallic/roughness or specular/glossiness, but that mean one could not mix models using different workflow in a same application.

@Moguri Moguri added the enhancement New feature or request label Sep 2, 2020
@rdb
Copy link
Collaborator

rdb commented Nov 3, 2022

I think this would require support for specular textures in Panda. We have "gloss" maps in Panda, but this is a single factor and not a colour.

I would not be opposed to adding M_specular and M_specular_gloss texture stage modes to Panda. The "gloss" slot would be reused to mean "glossiness" in the context (it's not exactly the same, but maybe it's close enough, and having separate "gloss" and "glossiness" would just be confusing).

This would be a change for 1.11 and not 1.10, panda3d-gltf would have to reject this extension when loading models into Panda3D 1.10.

Please file an upstream feature request for these texture modes.

@rdb
Copy link
Collaborator

rdb commented Nov 6, 2022

For the record, there is also the KHR_materials_specular extension now, which adds specular maps to the regular metallic-roughness model.

I'm a little annoyed that it has a competing definition of a specular texture, which is scaled by 0.04 (based on IOR of 1.5) but only when it is applied to a dielectric.

That makes me a little unsure about what meaning a "specular" slot should have when added to Panda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants