-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Object.freeze(Object) usage within sample #173
Comments
This code is just an example of injecting script, not a recommendation. I've opened a bug on our side to consider making the example more clear and less intrusive. Thanks! |
This very line seems to have made it into production for the MS Remote Help client (confirmed by debugger). We're having trouble with polyfills, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The "most basic" sample Win32_GettingStarted includes this line
This line of javascript freezes the
Object
prototype, making it immutable. This causes any website which includes polyfills that extend theObject
prototype to throw an error (and presumably not render anything). Polyfills are common place in web development. (More details MicrosoftEdge/WebView2Feedback#2035).Is there a specific reason this sample recommends freezing the
Object
prototype?The text was updated successfully, but these errors were encountered: