Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "auto commit message" collapses side bar #99

Open
MCGuilhermeGomes opened this issue May 30, 2023 · 10 comments
Open

Clicking "auto commit message" collapses side bar #99

MCGuilhermeGomes opened this issue May 30, 2023 · 10 comments

Comments

@MCGuilhermeGomes
Copy link

MCGuilhermeGomes commented May 30, 2023

Whenever I click the "auto commit message" button, it adds the message but collapses the bar (in my case the secondary bar) where the version control is present in vscode

@alexandrupetrini
Copy link

I have this issue too, it sort of crashes

@MCGuilhermeGomes
Copy link
Author

I notice that this does not happen if I click out of focus of the sidebar (for example If the focus is still on the text document). But If I click in the input box of the commit and then on the auto commit message button, it collapses the sidebar

@MichaelCurrin
Copy link
Owner

is this still an issue? I haven't seen it before.

@alexandrupetrini
Copy link

is this still an issue? I haven't seen it before.

I think I encountered it again this week (I use another ext because of that).
The problem is when you move the scm to the second panel. When you click on it, it will close it.

@MichaelCurrin
Copy link
Owner

I have nothing to go on here to see what error there might be or what extension it could be clashing with.

Can you setup the repo and run with the Debug mode so it opens the extension in a window? Then see if it can happen there - then check the Debug tab of the first window and see if there is an error there.

@MichaelCurrin
Copy link
Owner

also, what happens if you use CTRL+SHIFT+P to access the command prompt and then choose Auto Commit Message? See if that still gives the problem.

@alexandrupetrini
Copy link

also, what happens if you use CTRL+SHIFT+P to access the command prompt and then choose Auto Commit Message? See if that still gives the problem.

Basically it does not do anything.
The most important thing to notice here is that I use multi-folder workspaces.

Although it is acceptable to not run via command when a multi-folder workspace setup is in place, I still think it should work well when you click on the actual icon.

@MichaelCurrin MichaelCurrin pinned this issue Oct 30, 2023
@MichaelCurrin
Copy link
Owner

MichaelCurrin commented Oct 30, 2023

I am sorry, I still don't understand problem.

The multi folder workspace worked fine for me in the past (on Linux) and I retested it today (Windows and WSL Ubuntu) and that works fine for me.

The extension button works fine for both without closing the sidebar. There are two extension icons in view here and they both created the commit message text.

image

if you use the VS Code command prompt it defaults to the first repo.

@alexandrupetrini
Copy link

Then it is an issue from other extensions I have installed. I remember I tried another similar extension and it behaved the same way.

I also tried to run git-autocommit in debug mode but I couldn't figure it. I had a cold and couldn't get my thoughts straight then.

@alexandrupetrini
Copy link

alexandrupetrini commented Oct 31, 2023

Ok, I managed to spot the obvious (found the debug 😁 ) and I am able to provide some relevant feedback:

image

Case1:

  • Extension ran once and generated the message
  • Click on button
  • Secondary sidebar closes
    Output looks like this:

image

Case2:

  • Extension ran once and generated the message
  • Delete message text
  • Click on button
  • Secondary sidebar closes

image

It really does not matter if the file is staged or not:
image

I hope this helps.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants