Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action within input field #2299

Closed
eriknson opened this issue Mar 20, 2024 · 2 comments · Fixed by MetaMask/metamask-extension#24827
Closed

Action within input field #2299

eriknson opened this issue Mar 20, 2024 · 2 comments · Fixed by MetaMask/metamask-extension#24827
Assignees
@FrederikBolding
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0

Comments

@eriknson
Copy link
Member

eriknson commented Mar 20, 2024 •
edited

Let's introduce an (optional) action on the right-end of the input field (with the same available states as for any action)

input-field-with-action
@Montoya
Copy link
Collaborator

Montoya commented Apr 18, 2024

This is implemented in JSX, but needs to be implemented in extension UI.

@eriknson
Copy link
Member Author

eriknson commented May 2, 2024

@Mrtenz to explain how we expand our current input component to support this

@FrederikBolding FrederikBolding self-assigned this May 15, 2024
@FrederikBolding FrederikBolding mentioned this issue May 15, 2024
Merged
FrederikBolding added a commit that referenced this issue May 17, 2024
@FrederikBolding @metamaskbot
feat: add button within input field (#2407)
2fe9638 
Adds support for displaying buttons within a field. This PR is mostly
adding validation and types, there will be a follow-up PR in the
extension to actually implement the component.

Progresses #2299

---------

Co-authored-by: MetaMask Bot <[email protected]>
@FrederikBolding FrederikBolding mentioned this issue May 28, 2024
Merged
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump Snaps packages MetaMask/metamask-extension
4 participants
@Montoya @FrederikBolding @eriknson @metamaskbot