Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Double transactions triggered on Ledger Device #24335

Open
nikolay44u opened this issue May 1, 2024 · 6 comments
Open

[Bug]: Double transactions triggered on Ledger Device #24335

nikolay44u opened this issue May 1, 2024 · 6 comments
Assignees
Labels
external-contributor regression-prod-11.14.3 Regression bug that was found in production in release 11.14.3 Sev2-normal Normal severity; minor loss of service or inconvenience. team-hardware-wallets type-bug

Comments

@nikolay44u
Copy link

Describe the bug

After the latest update, Metamask extension seems to be trigerring a second transaction on Ledger hardware devices, after the first one has been manually approved on the Ledger device.

Workflow: On a dapp, I trigger a transaction, and approve it on the Metamask extension, and then finally approve it on Ledger HW and it gets broadcasted to the network. This should be the end of the transaction. However, after few seconds, the Ledger shows the same transaction again for approval with the same nonce.

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

  1. On a dapp, I trigger a transaction.
  2. Approve it on the Metamask extension,
  3. And then finally approve it on Ledger HW and the TX gets broadcasted to the network.

This should be the end of the transaction.

However, after few seconds, the Ledger shows the same transaction again for approval with the same nonce.

Error messages or log output

No response

Version

11.14.3

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

Ledger

Additional context

No response

Severity

Critical - tried on multiple devices

@metamaskbot metamaskbot added external-contributor regression-prod-11.14.3 Regression bug that was found in production in release 11.14.3 labels May 1, 2024
@vivek-consensys
Copy link

@nikolay44u can you please share what firmware version you are using on the Ledger device? Also, which Ledger device you are using?

@gauthierpetetin gauthierpetetin added the Sev2-normal Normal severity; minor loss of service or inconvenience. label May 2, 2024
@gauthierpetetin
Copy link
Contributor

Hi @MetaMask/hardware-wallets , I added a sev2 label for now but feel free to re-assess and turn this into a sev1 if needed.

@nikolay44u
Copy link
Author

@nikolay44u can you please share what firmware version you are using on the Ledger device? Also, which Ledger device you are using?

The Ledger Firmware version(updated to the latest version) is:
Secure Element 2.1.0
Microcontroller: 1.12

@vivek-consensys
Copy link

@nikolay44u can you please share what firmware version you are using on the Ledger device? Also, which Ledger device you are using?

The Ledger Firmware version(updated to the latest version) is: Secure Element 2.1.0 Microcontroller: 1.12

hi @nikolay44u , please update your firmware versions. I was not able to reproduce this issue using the following versions on Ledger Nano X:-

Secure Element - 2.2.3
Microcontroller - 2.30
Bootloader - 1.16

@nikolay44u
Copy link
Author

@nikolay44u can you please share what firmware version you are using on the Ledger device? Also, which Ledger device you are using?

The Ledger Firmware version(updated to the latest version) is: Secure Element 2.1.0 Microcontroller: 1.12

hi @nikolay44u , please update your firmware versions. I was not able to reproduce this issue using the following versions on Ledger Nano X:-

Secure Element - 2.2.3 Microcontroller - 2.30 Bootloader - 1.16

Im on the latest firmware as per Ledger Live. The app is also up-to date.

Screenshot 2024-05-03

My device is Ledger Nano S. Havent tried on the X yet.

It keeps happening on ETH network. Havent had this issue on another L2 network yet.

Same flow as outlined earlier - tx that was already approved on the Hw device, appears again for approval on the Hw device. I just now had to cancel one such tx on the device because it was already confirmed onchain 😅

@angelcheung22
Copy link

Pending support from Ledger team with nano s device. Issue cannot be reproduced from hardware wallet team on both nano X and nano S plus specific. Putting this to blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor regression-prod-11.14.3 Regression bug that was found in production in release 11.14.3 Sev2-normal Normal severity; minor loss of service or inconvenience. team-hardware-wallets type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

6 participants