chore: updating code owners file with design system team code ownership #24315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
the
team-design-system
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
… the design system team
georgewrmarshall
force-pushed
the
fix/24313/design-system-codeowners
branch
from
291db54
to
4af75a3
Compare
garrettbear
approved these changes
Apr 30, 2024
Builds ready [4af75a3]
Page Load Metrics (327 ± 393 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24315 +/- ##
========================================
Coverage 67.39% 67.39%
========================================
Files 1289 1289
Lines 50210 50210
Branches 13005 13005
========================================
Hits 33837 33837
Misses 16373 16373 ☔ View full report in Codecov by Sentry. |
danjm
approved these changes
May 14, 2024
Builds ready [d7e0714]
Page Load Metrics (773 ± 592 ms)
Bundle size diffs
|
metamaskbot
added
the
release-11.18.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the CODEOWNERS file to reflect the new code ownership assignments for the
ui/components/component-libraryfolder, assigning ownership to the @MetaMask/design-system-engineers team. This change is based on the recent organizational updates documented in this spreadsheet. The motivation behind this update is to ensure that the right team is notified for reviews on changes affecting the component library, thereby streamlining the review process and ensuring that changes align with our design system standards.Related issues
Fixes: #24313
Manual testing steps
As this change pertains to GitHub repository settings and does not directly impact the application's functionality, manual testing steps are not applicable. However, the effectiveness of this change can be observed in future PRs affecting the
ui/components/component-libraryfolder, where the @MetaMask/design-system-engineers team should automatically be requested for review.Screenshots/Recordings
Before
Not applicable - This change does not affect the visual or functional aspects of the application.
After
Not applicable - This change does not affect the visual or functional aspects of the application.
Pre-merge author checklist
Pre-merge reviewer checklist