Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design system team to codeowners #24313

Closed
9 tasks
georgewrmarshall opened this issue Apr 30, 2024 · 0 comments · Fixed by #24315
Closed
9 tasks

Add design system team to codeowners #24313

georgewrmarshall opened this issue Apr 30, 2024 · 0 comments · Fixed by #24315
Assignees
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

What is this about?

Add https://github.com/orgs/MetaMask/teams/design-system-engineers to code owners file for ownership over ui/components/component-library

Scenario

No response

Design

No response

Technical Details

  • Update .github/CODEOWNERS file

Threat Modeling Framework

No response

Acceptance Criteria

  • Design system team is added as a reviewer for all changes to the ui/components/component-library folder
  • Slack notifications is set up for design system engineers in the team channel

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@georgewrmarshall georgewrmarshall self-assigned this Apr 30, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Apr 30, 2024
georgewrmarshall added a commit that referenced this issue May 14, 2024
…ip (#24315)

## **Description**

This PR updates the CODEOWNERS file to reflect the new code ownership
assignments for the `ui/components/component-library` folder, assigning
ownership to the @MetaMask/design-system-engineers team. This change is
based on the recent organizational updates documented in [this
spreadsheet](https://docs.google.com/spreadsheets/d/1iSSQ9bTQ9apc7lzdxYheZ3P6eByH9E1y41WQx53036Q/edit#gid=0).
The motivation behind this update is to ensure that the right team is
notified for reviews on changes affecting the component library, thereby
streamlining the review process and ensuring that changes align with our
design system standards.

## **Related issues**

Fixes: #24313

## **Manual testing steps**

As this change pertains to GitHub repository settings and does not
directly impact the application's functionality, manual testing steps
are not applicable. However, the effectiveness of this change can be
observed in future PRs affecting the `ui/components/component-library`
folder, where the @MetaMask/design-system-engineers team should
automatically be requested for review.

## **Screenshots/Recordings**

### **Before**

*Not applicable - This change does not affect the visual or functional
aspects of the application.*

### **After**

*Not applicable - This change does not affect the visual or functional
aspects of the application.*

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability.
- [x] I’ve included a link to the relevant documentation or spreadsheet
justifying the change.
- [x] I’ve applied the right labels on the PR.

## **Pre-merge reviewer checklist**

- [x] I've reviewed the CODEOWNERS file update and confirmed it aligns
with the documented organizational changes.
- [x] I confirm that this PR does not require manual testing and
addresses the intended administrative change.

Co-authored-by: legobeat <[email protected]>
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants