feat: Remove ENABLE_CONFIRMATION_REDESIGN ENV variable from Signature Redesign related code #24312
Assignees
Labels
release-11.18.0
Issue or pull request that will be included in release 11.18.0
team-confirmations
Push issues to confirmations team
type-enhancement
Comments
7 tasks
|
Also enable the redesign preferences toggle by default for new users |
7 tasks
cryptotavares
added a commit
that referenced
this issue
May 10, 2024
## **Description** 🎉 Initial release for signatures redesign 🎉 Users will be able to toggle into the new confirmation pages for personal and typed data signatures. New users will have it enabled by default. [](https://codespaces.new/MetaMask/metamask-extension/pull/24466?quickstart=1) ## **Related issues** Fixes: #24312 ## **Manual testing steps** [Existing user:] 1. Go to experimental settings 2. Enable `Improved signature requests` 3. Go to test-dapp and test both personal sign and typed data sign (v1, v3 and v4) [New installation] 1. Remove the wallet and its data 2. Install it clean 3. Go through onboarding 5. Go to test-dapp and test both personal sign and typed data sign (v1, v3 and v4) ## **Screenshots/Recordings** **Before** | **After** :-------------------------:|:-------------------------: <img width="351" alt="Screenshot 2024-05-09 at 23 31 17" src="https://github.com/MetaMask/metamask-extension/assets/15957235/decb8cf2-6c9f-49bc-a4a2-78f46039c386"> |  <img width="356" alt="Screenshot 2024-05-09 at 23 37 00" src="https://github.com/MetaMask/metamask-extension/assets/15957235/b31cfc85-a710-4b3e-a177-8e39c0ef434c"> |  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/24466?quickstart=1){kind=link}
metamaskbot
added
the
release-11.18.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
We will no longer require the ENABLE_CONFIRMATION_REDESIGN ENV variable to show the new Signature Redesign for launch.
Remove ENABLE_CONFIRMATION_REDESIGN from Signature Redesign related code. ENABLE_CONFIRMATION_REDESIGN will continue to be used for our upcoming Transaction Redesigns.
Note: this issue should also cover enabling the preference toggle by default for new users.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: