Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Extension crashed after update while attempting to add a new snap account #24302

Open
plasmacorral opened this issue Apr 29, 2024 · 0 comments
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-11.16.0 release-11.16.0 Issue or pull request that will be included in release 11.16.0 Sev3-low Low severity; minimal to no impact upon users team-accounts type-bug

Comments

@plasmacorral
Copy link
Contributor

Describe the bug

Was testing the 11.16.0 RC commit d181619 with a load of accounts updating from 11.14.0 production. The Snap Simple Keyring seemed slow to respond and MM crashed in Chrome 117.0.5938.92 on Mac with Sonoma 14.3.1.

I have not been able to reproduce the issue, but I did follow the Chrome prompt to share and did download a copy of my statelogs. After reloading extension, I was able to add a Snap account successfully in v11.16.0 RC.

Expected behavior

No crash

Screenshots/Recordings

Recording:

11.16.0.RC.testing.-.Crash.mp4

Steps to reproduce

Several of these steps likely arent needed. However, since I have not reproduced I am sharing the details of what happened in the recording.

  1. Load up accounts in v11.14.0 (had Ledger, Trezor, QR, SSK v1.1.1 Snap, and Imported accounts all present)
  2. Have SSK open in browser and the snap connected and installed
  3. Update to 11.16.0
  4. Unlock wallet
  5. Open expanded view
  6. Download statelogs
  7. Change to a QR account
  8. Download statelogs again to show active account change
  9. have ledger device connected via USB but locked
  10. Attempt to add an additional Ledger account
  11. Not that device is not seen and unlock it and open Ethereum app
  12. Successfully add another Ledger address
  13. Open previously SSK dapp
  14. Click to Create account and note lack of response
  15. Minimize and then re-expand Create account method in dapp
  16. Note that CTA still doesnt respond
  17. Refresh dapp page
  18. Expand Create account
  19. Tap CTA to create account
  20. Note that MetaMask opens with an orange spinner, and then presents Cant open this page

Error messages or log output

No response

Version

11.16.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

Ledger, Trezor, Keystone

Additional context

Have not been able to reproduce but I do have statelogs
MetaMask state logs 11.16.0 RC crash.json

Severity

After reload, was able to proceed with the desired action

@plasmacorral plasmacorral added type-bug Sev3-low Low severity; minimal to no impact upon users team-accounts regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-11.16.0 Issue or pull request that will be included in release 11.16.0 labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-11.16.0 release-11.16.0 Issue or pull request that will be included in release 11.16.0 Sev3-low Low severity; minimal to no impact upon users team-accounts type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants