Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names to "main," "blocklist," and "allowlist." #9378

Open
LuckyLuker opened this issue Nov 10, 2022 · 5 comments
Open

Update names to "main," "blocklist," and "allowlist." #9378

LuckyLuker opened this issue Nov 10, 2022 · 5 comments
Assignees

Comments

@LuckyLuker
Copy link

LuckyLuker commented Nov 10, 2022

We want to push using allowlist, blocklist, and main branch terminology over whitelist, blacklist, and master branch.

From @Gudahtt: "We can migrate our config in eth-phishing-detect and change the main branch name from master to main, leaving the old master branch up with the deprecated config format to avoid breakages. We can even write GitHub actions to keep the old config up-to-date for some transition period, or indefinitely"

From @409H: f we change branch to main we will need to let codefi know so they can fetch from main instead of master

I see this code being used in at least 13 places: https://gitlab.com/search?group_id=7907658&scope=blobs&search=eth-phishing-detect Mainly Metafi and Activate use it.

I am notifying codefi about this issue and will post the slack link in a comment below.

@LuckyLuker
Copy link
Author

@409H
Copy link
Collaborator

409H commented Nov 17, 2022

Done :D

@409H 409H self-assigned this Nov 17, 2022
@AlexHerman1
Copy link
Collaborator

i think the aliases still appear as the old name schema in the config file? @409H @LuckyLuker

@legobeat
Copy link
Collaborator

legobeat commented Feb 21, 2023

There are some important pieces on compatibility here, both currently (main/master) and upcoming (allowlist/whitelist, blocklist/blacklist)

TODO:

  • Ensure users of MetaMask versions prior to 2022-11 use the correct and updated list
    • Previous versions will load from master which currently must be done regularly and manually until automatic syncing is in place. Example
    • This should be automated
  • Update clients and services to read from both new and old field names (allowlist as well as whitelist)
  • Update schema to use new names (allowlist instead of whitelist) in public-facing API
  • Decide on and announce deprecation timeline
    • (how old metamask versions should still be able to get benefits of phishing detection?)
  • Once deprecated: Complete deprecation of old field names by removing them
  • remove legacyConfig
  • change wording in docs

The sooner clients/consumers are forwards-compatible, the sooner we can consider deprecating the legacy names.

@12pfm6
Copy link

12pfm6 commented Feb 20, 2024

can our coin return that they stole?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants