-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update names to "main," "blocklist," and "allowlist." #9378
Comments
Codefi notified in slack: https://consensys.slack.com/archives/GTVGXR6P4/p1668109652473469 |
Done :D |
i think the aliases still appear as the old name schema in the config file? @409H @LuckyLuker |
There are some important pieces on compatibility here, both currently (main/master) and upcoming (allowlist/whitelist, blocklist/blacklist) TODO:
The sooner clients/consumers are forwards-compatible, the sooner we can consider deprecating the legacy names. |
can our coin return that they stole? |
We want to push using
allowlist
,blocklist
, andmain
branch terminology overwhitelist
,blacklist
, andmaster
branch.From @Gudahtt: "We can migrate our config in eth-phishing-detect and change the main branch name from master to main, leaving the old master branch up with the deprecated config format to avoid breakages. We can even write GitHub actions to keep the old config up-to-date for some transition period, or indefinitely"
From @409H: f we change branch to
main
we will need to let codefi know so they can fetch frommain
instead ofmaster
I see this code being used in at least 13 places: https://gitlab.com/search?group_id=7907658&scope=blobs&search=eth-phishing-detect Mainly Metafi and Activate use it.
I am notifying codefi about this issue and will post the slack link in a comment below.
The text was updated successfully, but these errors were encountered: