[tokens-controller] Expose getState action and stateChange event
#4271
Assignees
Labels
Comments
|
I don't think we need to update it to BaseControllerV2 necessarily, we just need to add the missing action and event |
|
Ah okok! I thought that it was something that we wanted to do to to every controller that it was still extending v1, sorry my mistake! |
|
Oh we definitely want to update everything to BaseControllerV2, but that might be a bit more challenging than just adding the missing action and event. Unsure in this case. We can solve this either way. |
MajorLift
changed the title
getState action and stateChange event
|
I agree that the BaseControllerV2 upgrade for TokensController should be tracked in its own ticket since it involves more tasks: #4075. I edited the title to reflect this and narrow the scope of this ticket. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With Token Detection Controller and Token Balances Controller, calling "TokensController:getState" action and subscribing "TokensController:stateChange" event, the Tokens Controller needs to be updated to extend Base Controller v2, to start to expose this action and this event and this action.
Where they are currently being used
Token Detection Controller:
core/packages/assets-controllers/src/TokenDetectionController.ts
Line 522 in 8769bd8
Token Balances Controller:
core/packages/assets-controllers/src/TokenBalancesController.ts
Line 143 in 4433150
The text was updated successfully, but these errors were encountered: