-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove providerConfig from NetworkController #4185
Labels
Comments
This was referenced May 2, 2024
This was referenced May 22, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Historically, the
providerConfig
property in NetworkController has been used to switch and track the currently selected network as well as provide access to information about that network. That is now achieved with a combination of theselectedNetworkClientId
andnetworkConfigurations
properties as well as theconfiguration
property on the NetworkClient interface. This means that we no longer needproviderConfig
and we can remove this redundant state.Removing
providerConfig
is one thing, but there are also a ton of packages which make use of this property to access the currently selected chain, and we would want to make use ofselectedNetworkClientId
in combination with theNetworkController:getNetworkClientById
action to do this instead.Acceptance Criteria
providerConfig
is removed from NetworkController (replaced withselectedNetworkClientId
and/or `networkConfigurations); NetworkController tests passAccountTrackerController
is updated to follow suit and tests passAssetsContractController
is updated to follow suit and tests passNftController
is updated to follow suit and tests passNftDetectionController
is updated to follow suit and tests passTokensController
is updated to follow suit and tests passTokenListController
is updated to follow suit and tests passTokenRatesController
is updated to follow suit and tests passEnsController
is updated to follow suit and tests passGasFeeController
is updated to follow suit and tests passSelectedNetworkController
tests are updated to follow suit and tests passTransactionController
is updated to follow suit and tests passThe text was updated successfully, but these errors were encountered: