-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is Layer Normalization in TransformerEncoderLayer2D placed in the correct position? #46
Comments
Yes, we implement satrn before the code released. We will update the satrn in the future. |
Good! I will keep this issue open for future fix about it! |
this bug is not fixed for now ???? |
We do some other jobs for now, i will fix it as soon as possible. |
ok,thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I found Layer Normalization is placed after self-attention and the residual connection in
TransformerEncoderLayer2D
.vedastr/vedastr/models/bodies/sequences/transformer/unit/encoder.py
Lines 60 to 63 in d617764
I think it is a common way of basic transformers, however, the official implementation of SATRN places it before. Do you have any plans to align your code to the original one, or basis for reliability?
The text was updated successfully, but these errors were encountered: