Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use resource/body object directly #364

Open
Maxim-Mazurok opened this issue Sep 24, 2020 · 2 comments
Open

Allow to use resource/body object directly #364

Maxim-Mazurok opened this issue Sep 24, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed investigation Needs to be investigated

Comments

@Maxim-Mazurok
Copy link
Owner

Instead of this:

await gapi.client.analyticsreporting.reports.batchGet({
  resource: {
    reportRequests: [/*...*/],
  },
});

we want to use this:

await gapi.client.analyticsreporting.reports.batchGet({
  reportRequests: [/*...*/],
});

First, we need to investigate if this is consistent across different APIs.
For example, body approach worked for Sheets API, but not for Analytics Reporting API.

@Maxim-Mazurok Maxim-Mazurok added enhancement New feature or request help wanted Extra attention is needed investigation Needs to be investigated labels Sep 24, 2020
@hakimio
Copy link

hakimio commented Sep 24, 2020

Not sure why directly specifying reportRequests for Analytics Reporting API doesn't work for you, because it works perfectly fine for me.

@Maxim-Mazurok
Copy link
Owner Author

You're right, direct approach also works fine for me. It's just that our current types definition does not support this direct approach.
So, this issue was created so that type definitions will be changed to allow this (totally valid and working) direct approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed investigation Needs to be investigated
Projects
None yet
Development

No branches or pull requests

2 participants