Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the usability of the editor #117

Open
krishnagopinath opened this issue Aug 5, 2017 · 6 comments
Open

Improve the usability of the editor #117

krishnagopinath opened this issue Aug 5, 2017 · 6 comments

Comments

@krishnagopinath
Copy link
Collaborator

The current Matterwiki editor (in the refactor branch) uses draft-js as its core editor. While this is good, there are wiggles, focus issues and other small issues that all add up to making the experience of using it sub-par. We could switch to a new editor or make the editor we have better. Any thoughts and suggestions would be helpful!

@krishnagopinath krishnagopinath added this to the 0.3.0 milestone Aug 5, 2017
@krishnagopinath krishnagopinath added this to Under Consideration in Matterwiki 0.3.0 Aug 5, 2017
@spaceraccoon
Copy link

spaceraccoon commented Aug 5, 2017 via email

@krishnagopinath
Copy link
Collaborator Author

I have seen tinyMCE too.

  • It's not React compatible in the way I'd like it to be (there was just a thin wrapper around the editor, iirc)
  • It feels like a closed source product (even though it IS open source) and all that.

I personally like draft-js, but if we cant get the UX we need out of it, we could consider http://slatejs.org/, which is similar to draft

@spaceraccoon
Copy link

spaceraccoon commented Aug 5, 2017 via email

@nshntarora
Copy link
Member

How about we check out Mobiledoc too? Not that elaborate as Slate. Slate still gets my vote. But a great piece of software http://bustle.github.io/mobiledoc-kit/demo/
Also, the guys at Ghost moved to a mobiledoc based editor in Ghost 1.0, but then again, their use case is just markdown.
What do you think @krishnagopinath and @spaceraccoon ?

I suggest, let's just make a list of all the editors and then do a pros-and-cons list. We have to ship a new editor (with image support) in the next version.

@krishnagopinath
Copy link
Collaborator Author

@nshntarora I think I'll start working on this next..

@krishnagopinath krishnagopinath self-assigned this Nov 13, 2017
@krishnagopinath krishnagopinath moved this from Under Consideration to Building in Matterwiki 0.3.0 Nov 13, 2017
@krishnagopinath
Copy link
Collaborator Author

krishnagopinath commented Nov 14, 2017

I'm leaning towards using slatejs on this one because

  • it seems to allow a little more customization through "plugins".. This is fantastic, because in the future, things could be easily made into its own package, if we started using lerna or yarn workspaces..

  • it just uses the DOM tree to represent the editor state, instead of its own structure (which fb/draft does), which is more intuitive and easy to reason about..

  • Easy moving around between HTML, MD and more! This is especially useful for us, because we need to support all these modes. Using draft would force us to re-invent the wheel on this one (Im sure it's possible, but we could be working on something else instead of this for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants