Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA Docs Forks #315

Merged
merged 1 commit into from
Sep 13, 2023
Merged

GHA Docs Forks #315

merged 1 commit into from
Sep 13, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Sep 12, 2023

When users submit PRs on forks, the documentation check will fail. This is because of how the git-auto-commit-action works with public repos. Seems like the correct (hopefully simple) solution is to changing the trigger

@dehume dehume linked an issue Sep 12, 2023 that may be closed by this pull request
GHA Documentation Flakiness #313
Open
bobbyiliev
bobbyiliev approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Looks good

@dehume dehume merged commit 8f3d949 into main Sep 13, 2023
1 check passed
@dehume dehume deleted the GHA-Docs-Forks branch September 13, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHA Documentation Flakiness
2 participants
@dehume @bobbyiliev