Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking 5.0.0 Changes #2255

Closed
27 tasks done
Keboo opened this issue Feb 19, 2021 · 4 comments
Closed
27 tasks done

Breaking 5.0.0 Changes #2255

Keboo opened this issue Feb 19, 2021 · 4 comments
Labels
breaking change Items here have breaking API changes. release notes Items are likely to be highlighted in the release notes.
Milestone
5.0.0

Comments

@Keboo
Copy link
Member

Keboo commented Feb 19, 2021 •
edited

There is an existing 5.0.0 branch where these changes are being made. Once we are a little closer to the release this branch will be merged into master. Anyone is welcome to pick up tasks here and PR into the 5.0.0 branch.

This is a list of proposed breaking changes for the 5.0.0 release. Feedback welcome!

  • Remove DrawerHostOpenMode.Model (Added in 4.0.0, Obsolete in 4.1.0)
  • Remove MaterialDesignScrollBarThumbVertical and MaterialDesignScrollBarThumbHorizontal replace with MaterialDesignScrollBarThumb
  • Consider making recommended theme color classes static.
    • Currently not possible because they implement the ISwatch interface.
  • Update ListBoxItem to use theme brush for hover color rather than deriving from the Foreground.
  • Update MenuItem to use theme brush for hover color rather than deriving from the Foreground.
  • There is a both usage of "Assist" and "Extensions" used. Consider standardizing on naming
  • Remove MaterialDesignRaisedAccentButton in favor of MaterialDesignRaisedSecondaryButton
  • Remove MaterialDesignFlatAccentButton in favor of MaterialDesignFlatSecondaryButton
  • Remove MaterialDesignFlatAccentBgButton in favor of MaterialDesignFlatSecondaryMidBgButton
  • Remove MaterialDesignFloatingActionMiniAccentButton in favor of MaterialDesignFloatingActionMiniSecondaryButton
  • Remove MaterialDesignFloatingActionAccentButton in favor of MaterialDesignFloatingActionSecondaryButton
  • Remove ComboBoxPopupPlacement
  • Remove obsolete members from ComboBoxPopup
  • Remove obsolete templates PopupContentUpTemplate and PopupContentDownTemplate
  • Remove obsolete brushes Theme brush rename #2435
  • Replace usages of "Accent" with "Secondary"
  • Remove "MaterialDesignNavigatilRailTabControl" it is replaced by "MaterialDesignNavigationRailTabControl"
  • Remove RatingBarButton.IsWithinSelectedValue property
  • Remove obsolete members from FlyoutAssist
  • Remove ShadowDepth
  • Remove ShadowAssist.ShadowEdges
  • Rename ShadowEdgeConverter to ShadowOpacityMaskConverter to better reflect its usage
  • Ensure all styles and brushes that contain the word "Accent" have been replaced with "Secondary"
  • Remove PickerInnerPaddingConverter (obsolete in PR Additional SmartHint refactoring #3181)
  • Rename all *Mixin classes to be *Extensions
  • Remove MaterialDesignTheme.Defaults.xaml in favor of people using either MaterialDesign2.Defaults.xaml or MaterialDesign3.Defaults.xaml
  • Ensure all removed obsolete styles exist in the Obsolete shim resource dictionary.
@Keboo Keboo added breaking change Items here have breaking API changes. release notes Items are likely to be highlighted in the release notes. labels Feb 19, 2021
@Keboo Keboo added this to the 5.0.0 milestone Feb 19, 2021
@Keboo Keboo pinned this issue Feb 19, 2021
@Keboo Keboo mentioned this issue Jul 7, 2021
Closed
@Keboo Keboo mentioned this issue Dec 21, 2021
Open
21 tasks
Keboo added a commit to Awsmolak/MaterialDesignInXamlToolkit that referenced this issue Feb 24, 2022
@Keboo
Allowing for backwards compat until 5.0.0
e52bdd4 
Added to the list on MaterialDesignInXAML#2255
Keboo added a commit that referenced this issue Feb 24, 2022
@Awsmolak @Keboo
Renamed MaterialDesignNavigatilRailTabControl to MaterialDesignNaviga… (
5ca41fa 
#2585)

* Renamed MaterialDesignNavigatilRailTabControl to MaterialDesignNavigationRailTabControl

* Allowing for backwards compat until 5.0.0

Added to the list on #2255

* Fixing my typo

Co-authored-by: Kevin Bost <[email protected]>
@Keboo Keboo mentioned this issue Jul 8, 2022
Merged
@jizc
Copy link
Contributor

jizc commented Jul 19, 2022

Might be good to add "Remove ShadowDepth" here. Context: #2786

@Keboo Keboo mentioned this issue Aug 22, 2022
Open
@Keboo Keboo mentioned this issue Nov 27, 2022
Open
@MichelMichels
Copy link
Member

MichelMichels commented May 18, 2023 •
edited

I'm in favor of dropping the netcoreapp3.1 target framework moniker as it reached it's end-of-life on December 13th, 2022. I'll make a pull request for it.

@Keboo Keboo closed this as completed Mar 3, 2024
@Pressacco Pressacco mentioned this issue Apr 20, 2024
Open
4 tasks
@cjmurph
Copy link
Contributor

cjmurph commented May 22, 2024

I think there is some missing breaking changes around the removal of ITheme and IBaseTheme interfaces. Maybe this is not the place? I couldn't find any reference to the removal of these interfaces anywhere else in regards to 4.9 -> 5.0

@DavidCFreire
Copy link

I think there is some missing breaking changes around the removal of ITheme and IBaseTheme interfaces. Maybe this is not the place? I couldn't find any reference to the removal of these interfaces anywhere else in regards to 4.9 -> 5.0

Same behavior here. Missing iTheme

@rmorgan001 rmorgan001 mentioned this issue May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Items here have breaking API changes. release notes Items are likely to be highlighted in the release notes.
Projects
MDIX - Issues Management
Status: Done
Milestone
5.0.0
Development

No branches or pull requests
5 participants
@Keboo @jizc @cjmurph @MichelMichels @DavidCFreire