Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.X] Replace future deprecated cgi.FieldStorage with multipart module #731

Merged

Conversation

girardinsamuel
Copy link
Contributor

@girardinsamuel girardinsamuel commented Oct 31, 2022

Fix #728.

Needs to add more unit tests to test different behaviours.

@girardinsamuel girardinsamuel changed the title Replace future deprecated cgi.FieldStorage with multipart module [5.X] Replace future deprecated cgi.FieldStorage with multipart module Nov 1, 2022
@girardinsamuel girardinsamuel changed the base branch from 4.0 to 5.0 November 1, 2022 14:09
@girardinsamuel girardinsamuel changed the base branch from 5.0 to 5.x November 1, 2022 14:16
Copy link
Member

@josephmancuso josephmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Why are we changing out cgi.FieldStorage with multipart?

@girardinsamuel
Copy link
Contributor Author

Because the module will be removed in future versions of Python 🙃

@josephmancuso josephmancuso marked this pull request as ready for review December 6, 2023 03:17
@josephmancuso josephmancuso merged commit 338ebb7 into MasoniteFramework:5.x Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace future deprecrated cgi module with other package
2 participants