Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] MSG_ATTACH_SD_MEDIA not defined in 2.1.2.2 #26940

Closed
ellensp opened this issue Apr 6, 2024 · 2 comments · Fixed by #27020
Closed

[BUG] MSG_ATTACH_SD_MEDIA not defined in 2.1.2.2 #26940

ellensp opened this issue Apr 6, 2024 · 2 comments · Fixed by #27020
Labels
Bug: Confirmed ! C: Language Fix Included A fix is included in the description

Comments

@ellensp
Copy link
Contributor

ellensp commented Apr 6, 2024 •
edited

Bug Description

MSG_ATTACH_SD_MEDIA is used by 2.1.2.2 but not defined in the code

Marlin\src\lcd\menu\menu_main.cpp:424:25: error: 'MSG_ATTACH_SD_MEDIA' is not a member of 'Language_en'; did you mean 'MSG_ATTACH_USB_MEDIA'?

Needs this line added to Marlin/src/lcd/language/language_en.h
LSTR MSG_ATTACH_SD_MEDIA = _UxGT("Attach SD Card");

Bug Timeline

Since 2.1.2.2 was released

Expected behavior

It should build

Actual behavior

Marlin\src\lcd\menu\menu_main.cpp:424:25: error: 'MSG_ATTACH_SD_MEDIA' is not a member of 'Language_en'; did you mean 'MSG_ATTACH_USB_MEDIA'?

Version of Marlin Firmware

2.1.2.2
@ellensp ellensp added Bug: Confirmed ! C: Language Fix Included A fix is included in the description labels Apr 6, 2024
@ellensp ellensp closed this as completed Apr 6, 2024
@ellensp
Copy link
Contributor Author

ellensp commented Apr 6, 2024

just added for the record

This was referenced Apr 27, 2024
Open
Merged
@thisiskeithb
Copy link
Member

Patch for 2.1.x submitted:

@thisiskeithb thisiskeithb linked a pull request Apr 27, 2024 that will close this issue
[2.1.x] 🩹 Fix missing MSG_ATTACH_SD_MEDIA define #27020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug: Confirmed ! C: Language Fix Included A fix is included in the description
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[2.1.x] 🩹 Fix missing MSG_ATTACH_SD_MEDIA define thisiskeithb/Marlin
2 participants
@ellensp @thisiskeithb