Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddNewAsync() methods to lists with AddNew which are using IObservableBindingList #3868

Open
StefanOssendorf opened this issue Apr 22, 2024 · 1 comment

Comments

@StefanOssendorf
Copy link
Contributor

IObservableBindingList currently only provides a method object AddNew();. This method internally uses a sync Create to create a new Item for the collection.
This is not usable - and can result in a deadlock - when async is required.

Add new methods to the following types and make sure to pass them down the inheritance chain if necessary (like to BusinessListBase).
IObservableBindingList

  • AddNewAsync()

ObservableBindingList

  • T AddNewAsync()

ViewModel

  • AddNewAsync()

ViewModelBase

  • BeginAddNewAsync
  • DoAddNewAsync
@rockfordlhotka
Copy link
Member

I don't think the viewmodel types will be affected.

The "BindingList" types exist to support Windows Forms. And maybe some WPF apps. All the UI frameworks after WPF do not honor or use the "BindingList" concepts (thankfully).

Also, any changes to the behavior of the "BindingList" types need to be thoroughly tested against Windows Forms data grid controls - at least the ones that are in-the-box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants