#3802 - replace null parameter with containingType #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is it possible to add a test for this? |
|
And did you sign the contribution agreement and send it to Rocky? |
Yes, I have the agreement. |
That makes sense. Let me update the PR with the test. |
|
@SimonCropp Test |
|
@19bibo85 Thank you for contributing and providing a test. But sadly the test does not verfiy the absence of the bug. I've reverted your fix in |
StefanOssendorf
requested changes
Apr 28, 2024
StefanOssendorf
approved these changes
Apr 29, 2024
|
@19bibo85 Thanks for your contribution! I'm just checking something organizational with rocky and will merge your PR as soon as that's resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3802 - Replace null parameter with containingType.