Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: ContainingType parameter isn't passed along instead null is used #3802

Closed
StefanOssendorf opened this issue Apr 16, 2024 · 0 comments · Fixed by #3891
Closed

Bug: ContainingType parameter isn't passed along instead null is used #3802

StefanOssendorf opened this issue Apr 16, 2024 · 0 comments · Fixed by #3891
Assignees
@19bibo85
Labels
flag/researching kind/bug kind/technical debt

Comments

@StefanOssendorf
Copy link
Contributor

csla/Source/Csla/PropertyInfo.cs

Lines 104 to 105 in 881c262

public PropertyInfo(string name, string friendlyName, Type containingType, RelationshipTypes relationship)
: this(name, friendlyName, null, DataBindingFriendlyDefault(), relationship)

This looks like a bug to me. The third parameter null in this() is actually Type containingType. But why isn't the parameter passed along but instead null used?
Is this a bug or intended?
19bibo85 added a commit to 19bibo85/csla that referenced this issue Apr 27, 2024
@19bibo85
MarimerLLC#3802 - replace null parameter with containingType
fd4bf2a
@19bibo85 19bibo85 mentioned this issue Apr 27, 2024
Merged
19bibo85 added a commit to 19bibo85/csla that referenced this issue Apr 28, 2024
@19bibo85
MarimerLLC#3802 - add test for containingType
83179c2
19bibo85 added a commit to 19bibo85/csla that referenced this issue Apr 28, 2024
@19bibo85
MarimerLLC#3802 - amend test for containingType
cba61e0
StefanOssendorf pushed a commit that referenced this issue Apr 30, 2024
@19bibo85
#3802 - replace null parameter with containingType (#3891)
2799406 
#3802 - replace null parameter with containingType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@19bibo85 19bibo85

Labels
flag/researching kind/bug kind/technical debt
Projects
CSLA Version 9.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3802 - replace null parameter with containingType 19bibo85/csla
3 participants
@rockfordlhotka @StefanOssendorf @19bibo85