Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parameter overloads for sync data portal Execute methods #3237

Open
rockfordlhotka opened this issue Dec 24, 2022 · 7 comments
Open

Comments

@rockfordlhotka
Copy link
Member

#1775 adds the ability to pass parameters to ExecuteAsync. This needs to be added to the sync Execute methods as well.

@mtavares628
Copy link

@rockfordlhotka Is there any ETA for this? With it being an oversight from the last release, I was hoping that it would be added to a service release. I only ask, because as I convert my project to CSLA 6, I would like to convert my Commands to this new methodology for both sync and async, but because sync isn't there yet, I've been having to stick with the old methodology.

@rockfordlhotka
Copy link
Member Author

I am working on it currently. It isn't easy to implement.

@mtavares628
Copy link

No worries. My apologies. I didn't realize the the level of effort for it. I thought it may have just been an oversight in terms of checking in the code when you had completed it for the async version. Thanks for putting in the time.

@rockfordlhotka
Copy link
Member Author

I want to do it right, and that is turning out to be more work than expected.

@rockfordlhotka
Copy link
Member Author

I'm sorry @mtavares628 - I think I conflated two different things.

What I'm working on that's very hard is making modern concepts work in ObjectFactory: #1707

What you are talking about is a simpler issue: (this thread). I just haven't had time to get to the sync Execute changes.

@mtavares628
Copy link

@rockfordlhotka no worries. I just saw that you bumped #1707 to v8 and that this issue has also been removed from v7. Will this also be bumped to v8 or is this more of a v7.0.1 issue?

@rockfordlhotka
Copy link
Member Author

Ha! You literally caught me mid-planning as I move things around 😳

Yes, I expect this is a 7.1.0 thing - I just need to get 7.0.0 moving - for my own sanity if nothing else.

@rockfordlhotka rockfordlhotka removed their assignment Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants