Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i know im years to late on this but still word of advice #12

Open
TotallyNotAHaxxer opened this issue Oct 28, 2021 · 1 comment
Open

Comments

@TotallyNotAHaxxer
Copy link

im sure you worked hard on this but HOLY MOTHER OF GOD THE CODE BURNS MY EYESSSSS

[1]: you didn't throw it under a main function? why, functions and definitions can help the code run faster, smoother, and even make the workflow a lot better if your collabing with other people

[2]: WHY os.system("clear") python is a very very VERY good language and is great for cross platform programs, this can easily work on windows if you change the statement under a def like this

def cle():
      if sys.platform == 'win32' or sys.platform == 'win64':
                                                os.system("cls")
      elif sys.platform == 'linux' or sys.platform == 'darwin':
                                                os.system("clear")

this can easily be replaced and ran throughout the script

[3]: the banners- why do you need banners for every option? i feel one banner makes the code very well- cleaner, and especially if your just gonna print 5 of them in one statement, it would actually be better to have it read to a file than it would be to just print it, that way you can call that function throughout the script with optional arguments of the file and design

@Scrut1ny
Copy link

Scrut1ny commented Feb 1, 2022

def cls():
os.system('cls' if os.name == 'nt' else 'clear')

I agree with everything you're saying btw 😂 just wanted to show what clear function I use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants