Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search Bar for Cloud Tenants Images and Instances Page #23002

Open
Rajkannan-2252 opened this issue Apr 25, 2024 · 13 comments
Open

Add Search Bar for Cloud Tenants Images and Instances Page #23002

Rajkannan-2252 opened this issue Apr 25, 2024 · 13 comments
Assignees

Comments

@Rajkannan-2252
Copy link

Hi @Fryguy,

I need to have a search bar for these pages,

When I go to Cloud Tenants, I can see the tenant user dashboard. In that dashboard, there are multiple images and instances, so I need a search option to filter the images or instances.

Path: Compute/Cloud/Tenants/Tenant Dashboard/Tenant Name (All Images), (All Instances)

Could you please guide me on how to add a search bar?

For your reference, I shared the screenshots below.

tenant images

instances cloud

@jeffibm
Copy link
Member

jeffibm commented Apr 29, 2024

Hey @Fryguy , implementing a search bar will be a time-consuming task much more than this. ManageIQ/manageiq-ui-classic#9159.

Possible ToDo's-

  • Reuse the react component (from the above PR) right above the line -cloud_tenant/show.html.haml#L8
  • or maybe need to think of a different way to do it.
  • Need a new GET request to filter the results.

We need to dig deep to find a solution.

In the meantime, @Rajkannan-2252 can refer to the previous PRs and post his findings here to discuss further.

@Rajkannan-2252
Copy link
Author

Hi @jeffibm,

Thank you for your response and for trying out the solution from the previous pull request. It's unfortunate that the search bar didn't appear on our page even after adding the React component above the specified line in the cloud_tenant/show.html.haml#L8 file.

@jeffibm
Copy link
Member

jeffibm commented Apr 29, 2024

Hi @jeffibm,

Hey @Rajkannan-2252 ,

Adding the component directly is not enough :)

You will have to improvise a bit to make it work.

I only suggested that you refer to the previous PR to get some ideas.

@Rajkannan-2252
Copy link
Author

Hello @jeffibm Thanks for the input.

We are trying this from our end too. Meanwhile, kindly let us know if you get any outputs for the same.

@Rajkannan-2252
Copy link
Author

Hello @jeffibm

"Based on our previous pull request, we're looking to incorporate the code snippet for the filter_with_name method. You can find it at this location:

def self.filter_with_name(name)

For this request, where should this code be added?

@jeffibm
Copy link
Member

jeffibm commented May 6, 2024

Hello @jeffibm

"Based on our previous pull request, we're looking to incorporate the code snippet for the filter_with_name method. You can find it at this location:

def self.filter_with_name(name)

For this request, where should this code be added?

Hey, @Rajkannan-2252 , I have no idea about this.

@Rajkannan-2252
Copy link
Author

"Hi @jeffibm,

I implemented the changes from the previous pull request as instructed. While I successfully added the search bar function to the cloud tenant page, I encountered an issue with filtering the search results.

I've provided screenshots below for your reference.

search 11

Thank you."

@jeffibm
Copy link
Member

jeffibm commented May 6, 2024

Hey @Rajkannan-2252 , I will have to debug this whole module before I can support you with answers, and it's way more complicated than the previous PR. we will let you know once the resources are available to work on this.
Thanks

@Rajkannan-2252
Copy link
Author

Hi @jeffibm, Thank you for the update.

Take your time with the debugging process.

@Rajkannan-2252
Copy link
Author

Hi @jeffibm,

Any updates on this PR?

@jeffibm
Copy link
Member

jeffibm commented May 16, 2024

Hi @jeffibm,

Any updates on this PR?

Hey @Rajkannan-2252 , no updates yet. will start on this when resources are released from high-priority tasks.

@Rajkannan-2252
Copy link
Author

Hello @jeffibm,

Got it! Just let me know when you're ready to proceed, and I'll be here to assist you with whatever you need.

@Rajkannan-2252
Copy link
Author

Hello @Fryguy ,

Any updates on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants