-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow /nickcolor #facade
as /nickcolor <#facade>
#116
Labels
enhancement
New feature or request
Comments
Love the idea! Because of the legacy format, I think the best way of doing this would be to try to parse what they originally wrote, and if that fails then try to parse it by adding |
Oh yeah, I forgot about legacy 😞. Doing the original first should work, that would also catch edge cases where the player's username is a colour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Soooo many people are confused about
/nickcolor
needing the angle brackets (<>
) for the commandDescribe the solution you'd like
Interpret
#rrggbb
as<#rrggbb>
andred
as<red>
Describe alternatives you've considered
The only other way that could benefit users would be to give a more helpful error message that is not just "You may only includes color codes."
Potential Implementation
Check if the argument has
<>
and add them if it doesn't before it's parsed, this would be a bit of a dirty implementation, but it would work well, and shouldn't break anything else.Basically, we take this
HexNicks/src/main/java/dev/majek/hexnicks/command/CommandNickColor.java
Lines 58 to 60 in 2afbedc
and add
If there is a concern about that failing, then we could put the "corrected" version in a new variable and use the old one if the colour code is detected to be wrong.
I'd be happy to open a PR with these changes, if feature is desired.
The text was updated successfully, but these errors were encountered: