Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 Rewrite - Added Journald check and reduced memory footprint #26

Merged
merged 65 commits into from
Jun 5, 2024
Merged

V2 Rewrite - Added Journald check and reduced memory footprint #26

merged 65 commits into from
Jun 5, 2024

Conversation

LukeShirnia
Copy link
Owner

@LukeShirnia LukeShirnia commented Apr 11, 2023 •
edited

Rewrite of oom analyzer to:

  • Check journald logs
  • Massively reduce memory footprint
    • Remove file size limit
  • Supports more Linux/Unix OS systems
  • Python 2.7 to 3.9 compatibility
  • Always show highest oom instance

Resolves #23
Resolves #17

To Do

  • Verify the total RAM at OOM Incident is being calculated correctly (seems a little "off" at the moment)
  • Do a quick scan (-q) if default system logs is empty
    • Provide option to select other options if oom instances are found elsewhere
  • Read "pages RAM" from kernel logs to get accurate RAM of system at time of incident
  • Add unit tests - specifically for regex to check journald/dmesg and system log files
  • Add black/pylint/isort github actions
  • Add python2.7-3.9 tests to make sure changes don't affect compatibility

Example Output

oomincident

LukeShirnia and others added 21 commits March 28, 2023 16:41
@LukeShirnia
Inital v2 commit - get system information
b6ebdef
@LukeShirnia
Added System.log_files to find appropriate kernel log location
058e944
@LukeShirnia
Black formatting and headers
cbb791d
@LukeShirnia
clean code and remove fstrings for python2.7 compatibility
84f83fb
@LukeShirnia
Added ram info and inital OOMAnalyzer class
a586ed2
@LukeShirnia
Fixed OOMAnalyzer.parse_killed_process_line() and added --reverse and…
7e1672e 
… --show options
@LukeShirnia
Removed accidental usage of f string
e833ed0
@LukeShirnia
added OOMAnalyzer.extract_timestamp() and fixed --show and --file args
05abcf1
@LukeShirnia
Updated OOMAnalyzer.is_process_line() for better error handling. Plus…
81a2ab8 
… added handling of gzip files
@LukeShirnia
Added better regex for killed services log extraction
d58e0ef
@LukeShirnia
Format oom instance output
f342c2d
@LukeShirnia
Always display highest oom incident
283ffa3
@LukeShirnia
Added basic --quick option and moved option validation to new function
4231dde
@LukeShirnia
Added System.search_log_dir(), fixed quick_check and updated output f…
9838203 
…ormatting
@LukeShirnia
Added python gitignore
772aaca
@LukeShirnia
Added ability to read journalctl logs
669a059
@LukeShirnia
Fix quick_check()
c851f9a
@LukeShirnia
Use generators to reduce memory footprint
b376dd6
@LukeShirnia
Remove file size limit as memory footprint is no longer an issue
4dc6d04
@LukeShirnia
Fixed no oom exception and python 2.7 compatibility regression
996f1a2
@LukeShirnia
Added --dmesg option and total service killed overview
2e180b7
@LukeShirnia LukeShirnia mentioned this pull request Apr 11, 2023
Open
@LukeShirnia LukeShirnia self-assigned this Jun 5, 2024
@LukeShirnia LukeShirnia merged commit 35189f6 into master Jun 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LukeShirnia LukeShirnia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: Add override for 300MB file limit Add journalctl compatibility
1 participant
@LukeShirnia