Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Incorrect commands #32

Closed
abhijeetviswa opened this issue Jan 7, 2024 · 1 comment · May be fixed by #46
Closed

doc: Incorrect commands #32

abhijeetviswa opened this issue Jan 7, 2024 · 1 comment · May be fixed by #46

Comments

@abhijeetviswa
Copy link

abhijeetviswa commented Jan 7, 2024

Setting this plugin up myself, and so far it's pretty amazing. So a couple of possible discrepancies/omissions in the documentation:

  1. In the section explaining the command structure:

Exceptions:
   Adapted boxes: x is a (for adapted) y is the position of the box.

I noticed that you x and y values can be swapped around i.e CBlabox seems equivalent to CBalbox

  1. In the Commands->Boxes section, the second to last entry in the table CBbaox[num] is incorrect. It should be CBacbox[num].

Nice work on the plugin.

@LudoPinelli
Copy link
Owner

I'm glad you like it so far!

  1. In the section explaining the command structure:

Exceptions:
   Adapted boxes: x is a (for adapted) y is the position of the box.

I noticed that you x and y values can be swapped around i.e CBlabox seems equivalent to CBalbox

I used CBalbox, CBacbox and CBarbox when I wrote the plugin at first, but for consistency in the nomenclature, those are deprecated in favor of CBlabox, CBcabox and CBrabox. And you're right, the explanation in the doc is not clear, I changed it a bit, I will replace the image for clarity later today.

  1. In the Commands->Boxes section, the second to last entry in the table CBbaox[num] is incorrect. It should be CBacbox[num].

Fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants