Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _addAriaLabelledBy in Dialog's CdkDialogContainer call once cdk dependency is >= 17.1 #2558

Open
Supamiu opened this issue Feb 9, 2024 · 0 comments
Labels
🔰 Good first issue Simple task to deal with if you are a new contributer 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.)

Comments

@Supamiu
Copy link
Contributor

Supamiu commented Feb 9, 2024

Context

For some reason that we couldn't identify, the CdkDialogContainer._addAriaLabelledBy method is only available in @angular/[email protected] and above while it's present in cdk's index.d.ts file even in 17.0.0.
In order to properly build the library, we decided to use _ariaLabelledByQueue.push instead, exposing ourselves to a possible Change Detection issue, as described in angular/components#28329.

Also, updating our dependency to @angular/cdk to something above the current version would be breaking for projects using @lucca-front/ng, which would make them have to update to Angular 17.1 or above, which is not needed except for this small risk.

Task

Once we moved to a version of @angular/cdk that's >= 17.1, ths call in packages/ng/dialog/dialog-header/dialog-header.component.ts that's in ngOnInit should be changed for an _addAriaLabelledBy call instead.

This will probably be done once we moved to Angular 18, somewhere around May 2024.

@Supamiu Supamiu added 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.) 🔰 Good first issue Simple task to deal with if you are a new contributer labels Feb 9, 2024
Supamiu added a commit that referenced this issue Feb 9, 2024
@jeremie-lucca jeremie-lucca modified the milestone: 17.5 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔰 Good first issue Simple task to deal with if you are a new contributer 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.)
Projects
None yet
Development

No branches or pull requests

2 participants