Use _addAriaLabelledBy
in Dialog's CdkDialogContainer
call once cdk dependency is >= 17.1
#2558
Labels
🔰 Good first issue
Simple task to deal with if you are a new contributer
🔨 Technical
Doesn't affect the output (refactor, dependencies update, cleaning, etc.)
Context
For some reason that we couldn't identify, the
CdkDialogContainer._addAriaLabelledBy
method is only available in@angular/[email protected]
and above while it's present in cdk'sindex.d.ts
file even in17.0.0
.In order to properly build the library, we decided to use
_ariaLabelledByQueue.push
instead, exposing ourselves to a possible Change Detection issue, as described in angular/components#28329.Also, updating our dependency to
@angular/cdk
to something above the current version would be breaking for projects using@lucca-front/ng
, which would make them have to update to Angular 17.1 or above, which is not needed except for this small risk.Task
Once we moved to a version of
@angular/cdk
that's >= 17.1, ths call inpackages/ng/dialog/dialog-header/dialog-header.component.ts
that's inngOnInit
should be changed for an_addAriaLabelledBy
call instead.This will probably be done once we moved to Angular 18, somewhere around May 2024.
The text was updated successfully, but these errors were encountered: