Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STEP export: Wrong device placement for models with non-zero transform #1387

Open
xotho opened this issue May 8, 2024 · 7 comments · May be fixed by #1401
Open

STEP export: Wrong device placement for models with non-zero transform #1387

xotho opened this issue May 8, 2024 · 7 comments · May be fixed by #1401
Assignees
Labels
bug export Issues related to any data export
Milestone

Comments

@xotho
Copy link

xotho commented May 8, 2024

VERSION / OS / ENVIRONMENT

LibrePCB Version: 1.1.1-unstable
Git Revision: 4d05a63
Build Date: 2024-05-06T08:58:42
Build Author: LibrePCB CI
Qt Version: 6.6.2 (built against 6.6.2)
CPU Architecture: x86_64
Operating System: Windows 11 Version 23H2
Platform Plugin: windows
TLS Library: OpenSSL 3.0.12 24 Oct 2023
OCC Library: OCCT 7.7.2

SUMMARY

Exported 3D-STEP show a PCB where a component mounted on BOTTOM side of the PCB is turned 180 degree.
In the LibrePCB all is shown correctly instead.

Wrong location about exported:
image

Right position shown in LibrePCB:
image

@ubruhin
Copy link
Member

ubruhin commented May 10, 2024

I don't understand from the pictures what is wrong. It doesn't even look like the same PCB is shown in both pictures 🤔

Can you please post the whole project (or send it to the contact email address on the website)?

@xotho
Copy link
Author

xotho commented May 10, 2024

Dear ubruhin,

check the following images, ( I removed some components ):

image

exported and imported in FREECAD or PTC:

1715339396134

  1. is the right view in LIBREPCB, 2) is the wrong view imported in FREECAD or PTC.

Should be clear I think.

Do you need more ?

@ubruhin
Copy link
Member

ubruhin commented May 14, 2024

I still cannot reproduce this, it would be very helpful to have your project for investigation. If you send it (as *.lppz export) to the contact email on our website, I'll handle it confidentially.

@xotho
Copy link
Author

xotho commented May 14, 2024

Pls Check contact Email.

take care

@ubruhin
Copy link
Member

ubruhin commented May 14, 2024

Got it, and can reproduce it! Thank you!

@ubruhin ubruhin added bug export Issues related to any data export labels May 14, 2024
@ubruhin ubruhin added this to the 1.2.0 milestone May 14, 2024
@xotho
Copy link
Author

xotho commented May 14, 2024

Great. Thank you 2 U.

@ubruhin ubruhin linked a pull request Jun 11, 2024 that will close this issue
@ubruhin
Copy link
Member

ubruhin commented Jun 11, 2024

OK this is really strange... The affected STEP model is a bit unusual because it contains a rotation of 180°, as shown in the FreeCAD object inspector:

image

But of course also this unusual case needs to be supported properly by LibrePCB. However, after exporting the PCB to STEP, this rotation is lost on the package:

image

I don't know why this happens, but I realized it can be fixed with a small change (see #1401). The output structure is then as expected:

image

And even the label "DEV1:1" is now correct, although this makes absolutely no sense to me. Also the change in #1401 makes no sense to me, but at least I didn't experience any negative impact on several projects I tested. That's the mystery of the OpenCascade API which I still don't understand at all...

I think we can go with this change for now and if any new issue pops up in future we have to investigate it again.

@xotho would be nice if you could test your complete project with the nightly build of #1401 (should appear in ca. an hour) and report here if the exported STEP is now correct.

@ubruhin ubruhin self-assigned this Jun 11, 2024
@ubruhin ubruhin changed the title STEP export issue STEP export: Wrong device placement for STEP models with non-zero transform Jun 11, 2024
@ubruhin ubruhin changed the title STEP export: Wrong device placement for STEP models with non-zero transform STEP export: Wrong device placement for models with non-zero transform Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug export Issues related to any data export
Development

Successfully merging a pull request may close this issue.

2 participants