Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Extract a new license page from AboutActivity #699

Open
2 tasks done
Goooler opened this issue Apr 15, 2023 · 2 comments
Open
2 tasks done

[FR] Extract a new license page from AboutActivity #699

Goooler opened this issue Apr 15, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Goooler
Copy link
Member

Goooler commented Apr 15, 2023

Checklist / 检查清单

  • No one has submitted a similar or identical feature request before. / 之前没有人提交过类似或相同的功能请求。
  • This suggestion does not depart from the original intention of LibChecker. / 这个建议不会背离 LibChecker 的初衷。

Enhancement propose / 改进目的

Show all OSS libs we used in LibChecker, as other projects did.

Solution / 解决方案

Generate artifacts JSON via Licensee, and paste it into res or assets, parse the JSON in runtime to show.

Additional info / 额外信息

No response
@Goooler Goooler added the enhancement New feature or request label Apr 15, 2023
@zhaobozhen
Copy link
Member

What are the advantages of doing this? Are there any best practices to follow?

@Goooler
Copy link
Member Author

Goooler commented May 31, 2023 •
edited

Show our OSS usages like other Apps did, and we can ref LawnchairLauncher/lawnchair#3492.

@qhy040404 qhy040404 changed the title [FR] Extract a new license page from AbountActivity [FR] Extract a new license page from AboutActivity Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Goooler @zhaobozhen