Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Link of comment is the link to the parent #2401

Open
5 tasks done
rakoo opened this issue Mar 27, 2024 · 1 comment
Open
5 tasks done

[Bug]: Link of comment is the link to the parent #2401

rakoo opened this issue Mar 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rakoo
Copy link

rakoo commented Mar 27, 2024

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Do you agree to follow the rules in our Code of Conduct?
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

In Lemmy the link to a comment (given by the chain icon) points to the parent.

Here's an example: comment https://lemmy.ml/comment/9675721 is a top-level comment. Its reply has the same link. The reply to the reply has link https://lemmy.ml/comment/9676388 points to the parent.

(you can check the content by curl-ing the comment: curl -L -H 'Accept: application/ld+json' https://lemmy.ml/comment/9676388

Steps to Reproduce

  1. Get the link to a comment, retrieve it with the previous curl command
  2. Check the content in the json ActivityPub object
  3. Check the content in the ui
  4. Both contents should be the same: they are not

Technical Details

I'm not using lemmy locally, I'm seeing it on multiple instances (sh.itjust.works, jlai.lu, lemmy.ml)

Version

0.19.3

Lemmy Instance URL

lemmy.ml, sh.itjustworks, jlai.lu
@rakoo rakoo added the bug Something isn't working label Mar 27, 2024
@Nutomic Nutomic transferred this issue from LemmyNet/lemmy Mar 27, 2024
@snan snan mentioned this issue Apr 2, 2024
Closed
5 tasks
@snan
Copy link
Contributor

snan commented Apr 2, 2024

More info here.

snan added a commit to snan/lemmy-ui that referenced this issue Apr 11, 2024
@snan
Fix parent comment linking when not showing context
0795b2f 
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.
For now, this commit tries to untangle two bugs caused by that.

One, there was a const `parentCommentId` that was always set even when
not having the `showContext` prop, causing the bug LemmyNet#2401.

Second, there was a const `title` which was conditionally set but then
not used, causing the title to always be "link" even when it shoulda
been "show_context".
@snan snan mentioned this issue Apr 11, 2024
Merged
snan added a commit to snan/lemmy-ui that referenced this issue Apr 11, 2024
@snan
Fix parent comment linking when not showing context
ab1cd11 
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.

There was a const `parentCommentId` that was always set even when not
having the `showContext` prop, causing the bug LemmyNet#2401.
snan added a commit to snan/lemmy-ui that referenced this issue Apr 11, 2024
@snan
Fix parent comment linking when not showing context
c6b16b1 
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.

There was a const `parentCommentId` that was always set even when not
having the `showContext` prop, causing the bug LemmyNet#2401.
snan added a commit to snan/lemmy-ui that referenced this issue Apr 11, 2024
@snan
Fix parent comment linking when not showing context
01123eb 
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.

There was a const `parentCommentId` that was always set even when not
having the `showContext` prop, causing the bug LemmyNet#2401.
snan added a commit to snan/lemmy-ui that referenced this issue Apr 11, 2024
@snan
Fix parent comment linking when not showing context
facb03e 
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.

There was a const `parentCommentId` that was always set even when not
having the `showContext` prop, causing the bug LemmyNet#2401.
snan added a commit to snan/lemmy-ui that referenced this issue Apr 11, 2024
@snan
Fix parent comment linking when not showing context
b99f666 
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.

There was a const `parentCommentId` that was always set even when not
having the `showContext` prop, causing the bug LemmyNet#2401.
dessalines pushed a commit that referenced this issue Apr 11, 2024
@snan
Fix parent comment linking when not showing context (#2417)
b983071 
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.

There was a const `parentCommentId` that was always set even when not
having the `showContext` prop, causing the bug #2401.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snan @rakoo