Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negatives for the OS checksum #89

Open
LegacyNsfw opened this issue Jan 23, 2019 · 0 comments
Open

False negatives for the OS checksum #89

LegacyNsfw opened this issue Jan 23, 2019 · 0 comments

Comments

@LegacyNsfw
Copy link
Owner

The OS checksum needs to exclude the parameter and calibration ranges. It currently doesn't exclude them, and a quirk of the checksum math enables it to give true positive results, but at the risk of false negatives.

If the parameter and calibration blocks have valid checksums, the app can still check for a valid OS checksum.

But, if the parameter or calibration blocks have invalid checksums, the app will report an invalid checksum for the OS as well, even if the OS blocks are actually valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant