Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App may hang if you press cancel while PCM is in recovery mode #114

Open
LegacyNsfw opened this issue Dec 13, 2019 · 0 comments
Open

App may hang if you press cancel while PCM is in recovery mode #114

LegacyNsfw opened this issue Dec 13, 2019 · 0 comments

Comments

@LegacyNsfw
Copy link
Owner

Seen with ELM-based devices, may or may not affect others.

The first loop in ElmDeviceImplementation.ReadElmLine doesn't check for \r characters. If the PCM is in recovery mode it will loop until the buffer is full, receiving the PCM's recovery-mode pings. This can take a very long time, and the app just appears hung.

Not sure what the side effects would be, though. Subsequent calls to ReadElmLine may or may not just pick up the read of the buffered messages. This would need a lot of testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant