Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] "Show implementation" shows the $.overload() code for overloaded functions #176

Open
LeaVerou opened this issue Mar 2, 2016 · 3 comments
Open

[Docs] "Show implementation" shows the $.overload() code for overloaded functions #176

LeaVerou opened this issue Mar 2, 2016 · 3 comments
Labels
bug

Comments

@LeaVerou
Copy link
Owner

LeaVerou commented Mar 2, 2016

Instead, it should show the function passed to overload.
@LeaVerou LeaVerou added the bug label Mar 2, 2016
@LeaVerou LeaVerou changed the title [Docs] "Show implementation" shows the source of $.overload() for overloaded functions [Docs] "Show implementation" shows the $.overload() code for overloaded functions Mar 2, 2016
@LeaVerou
Copy link
Owner Author

LeaVerou commented Mar 2, 2016

Perhaps we can modify the function’s toString() inside $.overload() to return the result of the toString() method on the wrapped function? Thoughts, @dperrymorrow?

@dperrymorrow
Copy link
Collaborator

yeah I see that issue,
tried to debug it a bit, where does $.sources get populated, I'm not sure i understand whats going on there.

@LeaVerou
Copy link
Owner Author

LeaVerou commented Mar 4, 2016

In the Bliss source, IIRC.

@stof stof mentioned this issue Aug 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dperrymorrow @LeaVerou