The IdentityVisitor has an implicit dependency on the PartialEvaluator visitor

[pelavall]

The chain of visitors which is fed into the WiqlQueryBuilder is required to be in a particular order. In the case of the IdentityVisitor, if the PartialEvaluator is not placed in line before the IdentityVisitor, it will not execute correctly as some of the expressions have not been simplified to the extent that the IdentityVisitor can interpret them.

As implemented there are no safeguards around constructing these types appropriately. We should revisit their implementation to make it such that you can only construct these types such that they will work as intended.