Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe away should be possible immediately #29

Open
funkenstrahlen opened this issue Jul 8, 2018 · 3 comments
Open

Swipe away should be possible immediately #29

funkenstrahlen opened this issue Jul 8, 2018 · 3 comments

Comments

@funkenstrahlen
Copy link

Expected behavior

  • Tap image and it opens up in SimpleImageViewer
  • Swipe away immediately to close again

Actual behavior

  • Tap image and it opens up in SimpleImageViewer
  • It does not react to swipe gestures right away. It takes more than 1s. Also X button to close takes some time to appear

I do not think this is a performance issue. This can be improved by changing the implementation.

@LcTwisk
Copy link
Owner

LcTwisk commented Jul 8, 2018

Hi! The delay you are experiencing is caused by the presentation transition which takes 0.5 seconds and is currently not interactive or cancellable. I personally think a transition of half a second is acceptable and I can’t think of a reason why a user would want to dismiss the vc before it’s even finished presenting. A simple solution might be to make the transition duration configurable ;)

Well, that’s how I think about it. Feel free to create a PR with improvements ;)

@funkenstrahlen
Copy link
Author

I understand!

A simple solution might be to make the transition duration configurable ;)

This would be a great solution for me! Can you make this possible?

@fukemy
Copy link

fukemy commented Mar 27, 2019

hi. im finding solution to make swipe image, that mean we can view a list of image instead of single

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants