Allow custom cards and bots simultaneously #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhvy
commented
Nov 21, 2023
| @@ -560,47 +585,6 @@ startGameProblems shared wrap wrapLobby users model remote = | |||
| |> Maybe.justIf (humanPlayerCount < 1) | |||
| ] | |||
|
|
|||
| disableRandoConfig = | |||
There was a problem hiding this comment.
Not sure if I should bring this back but check for "blank white cards only" instead to fix the above comment? And then I guess I'd need to hide the above error message I added in that case too...
| const result = this.cards.splice(0, toDraw); | ||
| const result = this.cards | ||
| .splice(0, toDraw) | ||
| .filter((card) => card.source.source !== "Custom"); |
There was a problem hiding this comment.
This may mean that blank cards aren't being discarded properly when picked up by the bot. Not sure?
lhvy
commented
Nov 30, 2023
Comment on lines
+458
to
+470
| -- Catch the case where "only blank white cards" is enabled. | ||
| numberOfNonBlankResponses = | ||
| case hr.comedyWriter of | ||
| Just { exclusive } -> | ||
| if exclusive then | ||
| 0 | ||
|
|
||
| else | ||
| summaries .responses | ||
|
|
||
| Nothing -> | ||
| summaries .responses | ||
|
|
There was a problem hiding this comment.
Need some feedback on this. Is this reasonable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #548
Updates the draw functions to ignore blank cards if the player drawing is a bot.