Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode Option #197

Open
lhvy opened this issue Oct 14, 2020 · 1 comment
Open

Dark Mode Option #197

lhvy opened this issue Oct 14, 2020 · 1 comment
Labels
client Issues that touch the client side of the game. enhancement A suggestion for a new feature or expansion of an existing feature. good-first-issue This issue would be a good one to pick if you want to contribute but are not sure where to start. Hacktoberfest This would be a good issue to pick up for Hacktoberfest. style Issues that only affect how the game looks.

Comments

@lhvy
Copy link
Contributor

lhvy commented Oct 14, 2020 •
edited

Describe the feature

A dark mode switch in the user settings that changes the colour scheme for those who prefer dark mode. Detecting the light/dark mode preference from the browser/OS would also be a nice-to-have.

The colours are currently defined in /client/src/scss/_colors.scss, so alternative colours would need to be added along with a way for the user to swap between colour profiles.
@lhvy lhvy added the enhancement A suggestion for a new feature or expansion of an existing feature. label Oct 14, 2020
@Lattyware Lattyware added the style Issues that only affect how the game looks. label Oct 14, 2020
@Lattyware
Copy link
Owner

Nice idea. It'd be pretty easy to do this with pure CSS by introducing some CSS custom properties (we already use these for cards) and using prefers-color-scheme.

@Lattyware Lattyware added client Issues that touch the client side of the game. good-first-issue This issue would be a good one to pick if you want to contribute but are not sure where to start. Hacktoberfest This would be a good issue to pick up for Hacktoberfest. labels Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client Issues that touch the client side of the game. enhancement A suggestion for a new feature or expansion of an existing feature. good-first-issue This issue would be a good one to pick if you want to contribute but are not sure where to start. Hacktoberfest This would be a good issue to pick up for Hacktoberfest. style Issues that only affect how the game looks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lattyware @lhvy