-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to enhance code quality #19
Comments
Did you fully understand the codebase? |
Hi @B-R-P, thanks for the response. I probably don't understand the codebase as in-depth as yourself and the other contributors. What I was really getting at with this issue is suggesting that a modular approach to the functions and classes in separate files would make it easier to maintain and contribute too. Or did you want to keep a single LangTrans.py file? |
I want it as a single file for now. I am assigning you (@thatvideoshopguy) to improve the code, as you mentioned above. |
Use docs to better understand the code and feel free to ask me if you have any questions. |
Description
Addressing multiple concerns, such as consistent naming conventions, splitting long functions, adding type hints, improving variable names, breaking down large functions, proper code formatting, and using f-strings can greatly enhance the code quality.
Example Improvements
In the
extract()
function, renamespattern
andtpattern
tosource_pattern
andtarget_pattern
for better readability. We could refactor theconvert()
function to separate the handling of part matches into a dedicated function.Could I be assigned to this issue to tackle these improvements comprehensively?
The text was updated successfully, but these errors were encountered: