Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini-langstream delete fails if other minikube clusters are defined #703

Open
Gagravarr opened this issue Nov 8, 2023 · 0 comments
Open

Comments

@Gagravarr
Copy link
Contributor

The mini-langstream delete command assumes that the mini-langstream cluster is the only one defined in minikube, and tries to both a delete and a purge (removing the .minikube folder)

However, if you have multiple clusters setup, eg

minikube profile list
|-----------------|-----------|---------|--------------|------|---------|---------|-------|--------|
|     Profile     | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|-----------------|-----------|---------|--------------|------|---------|---------|-------|--------|
| mini-langstream | docker    | docker  | 192.168.49.2 | 8443 | v1.27.4 | Running |     1 |        |
| minikube        | docker    | docker  | 192.168.49.2 | 8443 | v1.27.4 | Unknown |     1 | *      |
|-----------------|-----------|---------|--------------|------|---------|---------|-------|--------|

Then the call to delete will fail

mini-langstream delete
Deleting minikube: 📌  Multiple minikube profiles were found - 
📌      - mini-langstream
📌      - minikube

❌  Exiting due to MK_USAGE: Usage: minikube delete --all --purge

I would suggest that the delete call should first check if there are additional clusters defined. If there are, it should only delete the mini-langstream cluster (minikube delete -p mini-langstream) and probably just warn the user that the full minikube purge wasn't done due to other clusters still remaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant